Skip to content

Commit

Permalink
Merge pull request #432 from mainawycliffe/contributing-guidelines-up…
Browse files Browse the repository at this point in the history
…date

Add Commit Signing Requirements to Contributing Guidelines
  • Loading branch information
HofmannZ authored Oct 6, 2019
2 parents 23953b6 + 731518e commit 54868c4
Showing 1 changed file with 10 additions and 9 deletions.
19 changes: 10 additions & 9 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,18 +80,19 @@ Before you submit your Pull Request (PR) consider the following guidelines:
is necessary because release notes are automatically generated from these messages.

```shell
git commit -a
git commit -S -a
```

Note: the optional commit `-a` command line option will automatically "add" and "rm" edited files.
**Note:** the optional commit `-a` command line option will automatically "add" and "rm" edited files. While the options `-S` ensures are your commits are signed.

8. Push your branch to GitHub:
8. Make sure all of your commits are signed - follow instructions [here](https://help.github.com/en/articles/signing-commits) to learn how to sign your commits.
9. Push your branch to GitHub:

```shell
git push origin my-fix-branch
```
```shell
git push origin my-fix-branch
```

11. In GitHub, send a pull request to `graphql-flutter:beta`.
10. In GitHub, send a pull request to `graphql-flutter:beta`.

- If we suggest changes then:

Expand Down Expand Up @@ -204,8 +205,8 @@ The scope should be the name of the package affected (as perceived by the person
The following is the list of supported scopes:
- **client**: For GraphQL Client Package
- **flutter**: For updates realted to Flutter GraphQL package
- **packaging**: For pub dependancy updates
- **flutter**: For updates related to Flutter GraphQL package
- **packaging**: For pub dependency updates
- **upgrade**
- **changelog**
Expand Down

0 comments on commit 54868c4

Please # to comment.