Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update README.md #1003

Merged
merged 2 commits into from
Jan 7, 2022
Merged

update README.md #1003

merged 2 commits into from
Jan 7, 2022

Conversation

adnanjpg
Copy link
Contributor

@adnanjpg adnanjpg commented Jan 6, 2022

Docs

  • Updated graphql_flutter/README.md

@request-info
Copy link

request-info bot commented Jan 6, 2022

We would appreciate it if you could provide us with more info about this issue/pr!

@request-info request-info bot added the needs more info More information is required label Jan 6, 2022
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the code in the readme, I was thinking to remove it but for now, I have comment unrelated to the code

packages/graphql_flutter/README.md Outdated Show resolved Hide resolved
packages/graphql_flutter/README.md Outdated Show resolved Hide resolved
@vincenzopalazzo vincenzopalazzo self-assigned this Jan 6, 2022
@vincenzopalazzo vincenzopalazzo added 🚄 doc & examples requests for documentation, usage examples, and support and removed needs more info More information is required labels Jan 6, 2022
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #1003 (67ef1a8) into beta (cd141d0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             beta    #1003   +/-   ##
=======================================
  Coverage   31.88%   31.88%           
=======================================
  Files           8        8           
  Lines         207      207           
=======================================
  Hits           66       66           
  Misses        141      141           
Flag Coverage Δ
graphql_client 31.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0793fd...67ef1a8. Read the comment docs.

Copy link
Contributor Author

@adnanjpg adnanjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vincenzopalazzo , I've accepted your suggestions. please check it out

@adnanjpg
Copy link
Contributor Author

adnanjpg commented Jan 6, 2022

I think I've accepted your suggestions but I'm not sure it worked, Sorry I'm new to this

@vincenzopalazzo
Copy link
Collaborator

I think I've accepted your suggestions but I'm not sure it worked, Sorry I'm new to this

you need to change your code, and make another commit after that you change are reflected on the PR

Co-authored-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to make this work :)

Hope to see more contribution on this repository

@vincenzopalazzo vincenzopalazzo merged commit 7506c86 into zino-hofmann:beta Jan 7, 2022
@vincenzopalazzo vincenzopalazzo added this to the v5.0.1 milestone Jan 7, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🚄 doc & examples requests for documentation, usage examples, and support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants