Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

graphql: restore ws test by introducing a ws echo server written in dart #1010

Merged
merged 2 commits into from
Jan 16, 2022

Conversation

vincenzopalazzo
Copy link
Collaborator

Fixes #980

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
@vincenzopalazzo vincenzopalazzo self-assigned this Jan 16, 2022
@vincenzopalazzo vincenzopalazzo added 🔨 tests Relates to testing ⚡ websocket Web Socket Related labels Jan 16, 2022
@vincenzopalazzo vincenzopalazzo added this to the v5.0.1 milestone Jan 16, 2022
@vincenzopalazzo vincenzopalazzo force-pushed the vincenzopalazzo/dev branch 2 times, most recently from 1d37be0 to cc769dd Compare January 16, 2022 12:41
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
@codecov
Copy link

codecov bot commented Jan 16, 2022

Codecov Report

Merging #1010 (eb0b83d) into beta (a736d02) will increase coverage by 19.26%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             beta    #1010       +/-   ##
===========================================
+ Coverage   31.88%   51.15%   +19.26%     
===========================================
  Files           8       36       +28     
  Lines         207     1345     +1138     
===========================================
+ Hits           66      688      +622     
- Misses        141      657      +516     
Flag Coverage Δ
graphql_client ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/graphql/lib/src/core/query_result.dart 48.00% <0.00%> (ø)
packages/graphql/lib/src/cache/fragment.dart 20.45% <0.00%> (ø)
packages/graphql/lib/src/core/fetch_more.dart 0.00% <0.00%> (ø)
...raphql/lib/src/cache/_optimistic_transactions.dart 78.94% <0.00%> (ø)
packages/graphql/lib/src/utilities/helpers.dart 91.30% <0.00%> (ø)
packages/graphql/lib/src/core/_data_class.dart 16.66% <0.00%> (ø)
...b/src/links/websocket_link/websocket_messages.dart 47.50% <0.00%> (ø)
...ackages/graphql/lib/src/core/observable_query.dart 42.37% <0.00%> (ø)
packages/graphql/lib/src/cache/store.dart 100.00% <0.00%> (ø)
...es/graphql/lib/src/core/_query_write_handling.dart 65.38% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a736d02...eb0b83d. Read the comment docs.

@vincenzopalazzo vincenzopalazzo merged commit 9a4085c into beta Jan 16, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🔰 ci/cd 🔨 tests Relates to testing ⚡ websocket Web Socket Related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ws services: Change the echo ws services with a internal server
2 participants