-
-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use flutter pub add
to add dependencies
#1033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Can you just squash the commit in a single one?
Thanks!
Looks like I'm holding the tool wrong. The Github desktop app is complaining "Unable to squash. Squashing replays all commits up to the last one required for the squash. A merge commit cannot exist among those commits." Feel free to either squash this PR on commit, or re-manufacture it as appropriate. |
5a506df
1bcc3a0
to
5a506df
Compare
5a506df
to
33bd161
Compare
33bd161
to
0a6b3f7
Compare
Yeah, this is because merge and squash are mutually exclusive, and maybe I'm too biased with the squash to maintain the history clean. Anyway, to keep you as the author of the commit, I remove just the merge commit and change the commit message. Otherwise, if I will squash, you lost the authority on the commit. Thanks to contribute in this repository :) |
Use `flutter pub add` to add dependencies
Describe the purpose of the pull request.
Docs