Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use flutter pub add to add dependencies #1033

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

domesticmouse
Copy link
Contributor

Describe the purpose of the pull request.

Docs

  • Updated package READMEs.

budde377
budde377 previously approved these changes Feb 10, 2022
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Can you just squash the commit in a single one?

Thanks!

@domesticmouse
Copy link
Contributor Author

Looks like I'm holding the tool wrong. The Github desktop app is complaining "Unable to squash. Squashing replays all commits up to the last one required for the squash. A merge commit cannot exist among those commits."

Feel free to either squash this PR on commit, or re-manufacture it as appropriate.

@vincenzopalazzo vincenzopalazzo self-assigned this Feb 10, 2022
@vincenzopalazzo vincenzopalazzo dismissed stale reviews from budde377 and themself via 5a506df February 10, 2022 12:47
@vincenzopalazzo vincenzopalazzo added the 🚄 doc & examples requests for documentation, usage examples, and support label Feb 10, 2022
@vincenzopalazzo
Copy link
Collaborator

Looks like I'm holding the tool wrong. The Github desktop app is complaining "Unable to squash. Squashing replays all commits up to the last one required for the squash. A merge commit cannot exist among those commits."

Yeah, this is because merge and squash are mutually exclusive, and maybe I'm too biased with the squash to maintain the history clean.

Anyway, to keep you as the author of the commit, I remove just the merge commit and change the commit message. Otherwise, if I will squash, you lost the authority on the commit.

Thanks to contribute in this repository :)

@vincenzopalazzo vincenzopalazzo merged commit f198147 into zino-hofmann:beta Feb 10, 2022
budde377 pushed a commit that referenced this pull request Feb 13, 2022
Use `flutter pub add` to add dependencies
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🚄 doc & examples requests for documentation, usage examples, and support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants