Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Add .pubignore and dependency #1068

Merged
merged 1 commit into from
Mar 15, 2022
Merged

fix: Add .pubignore and dependency #1068

merged 1 commit into from
Mar 15, 2022

Conversation

budde377
Copy link
Collaborator

This PR adds tests to .pubignore to reduce package size and removes dependency override.

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #1068 (f1de5eb) into main (4d91cb0) will decrease coverage by 15.34%.
The diff coverage is n/a.

❗ Current head f1de5eb differs from pull request most recent head 10267fb. Consider uploading reports for the commit 10267fb to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1068       +/-   ##
===========================================
- Coverage   55.81%   40.47%   -15.35%     
===========================================
  Files          41       13       -28     
  Lines        1521      210     -1311     
===========================================
- Hits          849       85      -764     
+ Misses        672      125      -547     
Impacted Files Coverage Δ
packages/graphql/lib/src/links/auth_link.dart
...es/graphql/lib/src/exceptions/exceptions_next.dart
...ackages/graphql/lib/src/core/observable_query.dart
...ackages/graphql/lib/src/exceptions/network_io.dart
packages/graphql/lib/src/cache/hive_store.dart
packages/graphql/lib/src/core/fetch_more.dart
...ackages/graphql/lib/src/core/mutation_options.dart
packages/graphql/lib/src/utilities/helpers.dart
packages/graphql/lib/src/core/policies.dart
...graphql/lib/src/cache/_normalizing_data_proxy.dart
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81e8a18...10267fb. Read the comment docs.

@vincenzopalazzo vincenzopalazzo self-requested a review March 15, 2022 13:16
@vincenzopalazzo vincenzopalazzo added the enhancement New feature or request label Mar 15, 2022
@vincenzopalazzo vincenzopalazzo added this to the v5.1.0 milestone Mar 15, 2022
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks!

@vincenzopalazzo vincenzopalazzo merged commit 8a10d4d into main Mar 15, 2022
@budde377 budde377 deleted the fix-publish-2 branch March 16, 2022 06:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants