Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Send payload in PingMessage #1374

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

Rochak69
Copy link
Contributor

@Rochak69 Rochak69 commented Aug 30, 2023

Send payload in PingMessage

@vincenzopalazzo
Copy link
Collaborator

Thanks, can you drop the merge commit here 28754d9 and use the rebase?

thanks

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 96.66% and project coverage change: +0.51% 🎉

Comparison is base (6eaa2d2) 63.67% compared to head (fb560c0) 64.19%.
Report is 8 commits behind head on main.

❗ Current head fb560c0 differs from pull request most recent head 19d5c86. Consider uploading reports for the commit 19d5c86 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1374      +/-   ##
==========================================
+ Coverage   63.67%   64.19%   +0.51%     
==========================================
  Files          41       41              
  Lines        1696     1715      +19     
==========================================
+ Hits         1080     1101      +21     
+ Misses        616      614       -2     
Files Changed Coverage Δ
...lib/src/links/websocket_link/websocket_client.dart 82.60% <96.66%> (+2.51%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincenzopalazzo vincenzopalazzo force-pushed the main branch 2 times, most recently from c59282d to e6d68a1 Compare August 30, 2023 09:01
I am using it to send information about the workspaces I want to stay
online for because there are multiple workspaces.
@joshisijan
Copy link

joshisijan commented Sep 1, 2023

Thank you @vincenzopalazzo for addressing this issue. When will the new release be published in pub.dev?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants