-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(op): Server interface #447
Conversation
Codecov Report
@@ Coverage Diff @@
## next #447 +/- ##
==========================================
+ Coverage 54.15% 58.39% +4.23%
==========================================
Files 75 78 +3
Lines 5724 6542 +818
==========================================
+ Hits 3100 3820 +720
- Misses 2369 2426 +57
- Partials 255 296 +41
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i also found some flakiness in the tests
🎉 This PR is included in version 3.0.0-next.11 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR bring the new Server interface as described in #440 and adds:
op.Server
interface;op.webServer
: a HTTP handler taking care of routing and request parsing and validating required request fields.op.LegacyServer
: a wrapper around the currentOpenIDProvider
andStorage
interfaces.The interface should be considered experimental.
The following tests have been provided:
op.webServer
(near 100%)LegacyServer
. Some test error outcomes are different, due to the different order of things being validated. (For example client verification is done in a more centralized manner as the old implementation).op.Provider
andop.LegacyServer