Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add shell to configuration file #302

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Add shell to configuration file #302

merged 2 commits into from
Mar 28, 2023

Conversation

lsvmello
Copy link
Contributor

Closes #300

I didn't added the logic to windows because it gets a little more complicated there. Most shell on linux uses the -c flag but on windows the flag might be completely different: /c for cmd, -NoInteractive for powershell and -c for zsh, bash and fish.

Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this, and in particular for filling the documentation 👍

internal/util/os/os.go Show resolved Hide resolved
docs/config.md Show resolved Hide resolved
Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @lsvmello!

@mickael-menu mickael-menu merged commit a8d1db4 into zk-org:main Mar 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config.toml should support all environment variable configurations
2 participants