Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Apply memory leak in zoo_multi API patch #62

Closed
wants to merge 1 commit into from
Closed

Conversation

yuui
Copy link

@yuui yuui commented May 28, 2014

@eric
Copy link
Member

eric commented May 28, 2014

Do you see anywhere in the ruby library that is actually using the zoo_multi call?

I see in ext/zkrb_wrapper.c that we're wrapping the methods, but it doesn't appear that we're actually calling any of them.

@yuui
Copy link
Author

yuui commented May 29, 2014

Sorry. I grep all across the gem source files, and I see the zoo_multi is not called anywhere as you say.

@slyphon
Copy link
Contributor

slyphon commented Jun 2, 2014

yeah, i'd converted it a while back to do zoo_single (or w/e) for single-threaded usage, as ruby gets REALLY ANGRY when you have alien POSIX threads call into the the interpreter :)

@yuui
Copy link
Author

yuui commented Jun 11, 2014

Thank you, @slyphon. I could understand why zoo_multi isn't used for this gem :)

@yuui yuui closed this Jun 11, 2014
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants