add HTMLCollection#@@iterator for some browsers, #37, #68

zloirock · May 21, 2015 · 558a0b9 · 558a0b9
1 parent cfe654a
commit 558a0b9
Show file tree

Hide file tree

Showing 6 changed files with 60 additions and 12 deletions.
diff --git a/library/modules/web.dom.iterable.js b/library/modules/web.dom.iterable.js
@@ -3,8 +3,12 @@ var $           = require('./$')
   , Iterators   = require('./$.iter').Iterators
   , ITERATOR    = require('./$.wks')('iterator')
   , ArrayValues = Iterators.Array
-  , NodeList    = $.g.NodeList;
-if($.FW && NodeList && !(ITERATOR in NodeList.prototype)){
-  $.hide(NodeList.prototype, ITERATOR, ArrayValues);
+  , NL          = $.g.NodeList
+  , HTC         = $.g.HTMLCollection
+  , NLProto     = NL && NL.prototype
+  , HTCProto    = HTC && HTC.prototype;
+if($.FW){
+  if(NL && !(ITERATOR in NLProto))$.hide(NLProto, ITERATOR, ArrayValues);
+  if(HTC && !(ITERATOR in HTCProto))$.hide(HTCProto, ITERATOR, ArrayValues);
 }
-Iterators.NodeList = ArrayValues;
+Iterators.NodeList = Iterators.HTMLCollection = ArrayValues;
diff --git a/modules/web.dom.iterable.js b/modules/web.dom.iterable.js
@@ -3,8 +3,12 @@ var $           = require('./$')
   , Iterators   = require('./$.iter').Iterators
   , ITERATOR    = require('./$.wks')('iterator')
   , ArrayValues = Iterators.Array
-  , NodeList    = $.g.NodeList;
-if($.FW && NodeList && !(ITERATOR in NodeList.prototype)){
-  $.hide(NodeList.prototype, ITERATOR, ArrayValues);
+  , NL          = $.g.NodeList
+  , HTC         = $.g.HTMLCollection
+  , NLProto     = NL && NL.prototype
+  , HTCProto    = HTC && HTC.prototype;
+if($.FW){
+  if(NL && !(ITERATOR in NLProto))$.hide(NLProto, ITERATOR, ArrayValues);
+  if(HTC && !(ITERATOR in HTCProto))$.hide(HTCProto, ITERATOR, ArrayValues);
 }
-Iterators.NodeList = ArrayValues;
+Iterators.NodeList = Iterators.HTMLCollection = ArrayValues;
diff --git a/tests/tests-library.js b/tests/tests-library.js
diff --git a/tests/tests-library/web.dom.itarable.ls b/tests/tests-library/web.dom.itarable.ls
@@ -0,0 +1,11 @@
+QUnit.module 'DOM iterable'
+
+isFunction = -> typeof! it is \Function
+
+if NodeList? and document?querySelectorAll and typeof! document.querySelectorAll(\div) is \NodeList
+  test 'NodeList.prototype@@iterator' !->
+    ok core.isIterable(document.querySelectorAll(\div)), 'Is iterable'
+
+if HTMLCollection? and document?getElementsByTagName and typeof! document.getElementsByTagName(\div) is \HTMLCollection
+  test 'HTMLCollection.prototype@@iterator' !->
+    ok core.isIterable(document.getElementsByTagName(\div)), 'Is iterable' # Buggy in some Chromium versions
diff --git a/tests/tests.js b/tests/tests.js
diff --git a/tests/tests/web.dom.itarable.ls b/tests/tests/web.dom.itarable.ls
@@ -2,5 +2,10 @@ QUnit.module 'DOM iterable'
 
 isFunction = -> typeof! it is \Function
 
-if NodeList? => test 'NodeList.prototype@@iterator' !->
-  ok isFunction(NodeList.prototype[Symbol.iterator]), 'Is function'
+if NodeList? and document?querySelectorAll and document.querySelectorAll(\div) instanceof NodeList
+  test 'NodeList.prototype@@iterator' !->
+    ok isFunction(document.querySelectorAll(\div)[Symbol.iterator]), 'Is function'
+
+if HTMLCollection? and document?getElementsByTagName and document.getElementsByTagName(\div) instanceof HTMLCollection
+  test 'HTMLCollection.prototype@@iterator' !->
+    ok isFunction(document.getElementsByTagName(\div)[Symbol.iterator]), 'Is function' # Buggy in some Chromium versions