Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Since 3.6.2 breaks build in Firefox 17 #764

Closed
infodusha opened this issue Feb 4, 2020 · 7 comments
Closed

Since 3.6.2 breaks build in Firefox 17 #764

infodusha opened this issue Feb 4, 2020 · 7 comments

Comments

@infodusha
Copy link

No errors found, but i see only white screen.
Can't understand how that can be. I think something browser-specific happens.
Besides, in Chrome 79 all is ok.
Downgrade to 3.6.1 helps.

@samjetski

This comment has been minimized.

@irbian
Copy link

irbian commented Mar 18, 2020

I´m experiencing the same behaviour on wkhtmltopdf / QtWeb, that matches a Chrome 12/13. 3.6.1 works, 3.6.2, not

@irbian

This comment has been minimized.

@zloirock
Copy link
Owner

zloirock commented Nov 6, 2020

What about actual versions? In core-js@3.6.2 was added detection of incorrect ToLength conversion in Array methods. After that detection was changed to safer.

@olemartinorg
Copy link

I'm having similar problems, but I get an error in my console: Uncaught TypeError: can't convert V8VERSION to number. This happens because the export from engine-v8-version.js is undefined, and probably because of some intricacies in module loading I don't know much about, the imported value is a special Object {default: undefined} which cannot be converted to a number. In a chrome-based browser, this value will be of type number.

I looked around, and v8-version.js was extracted from the Promise polyfill in v3.3.5, and was later renamed to engine-v8-version.js in v3.6.2. Other than that rename operation, no new modules seem to be importing engine-v8-version in v3.6.2, and I'm able to reproduce the TypeError all the way down to v3.3.5.

I'm tempted to just submit a pull request to just export || 0 when the match returns undefined.

@terencehonles
Copy link

For those on Qt webkit this patch seems to fix my issue #911 not sure if it helps with the FF in question.

@zloirock
Copy link
Owner

I dropped ToLength detection from array methods feature detection since it could cause hanging of some old engines and I don't see any possible workaround which could work everywhere.

terencehonles pushed a commit to terencehonles/core-js that referenced this issue Feb 16, 2021
which could cause hanging FF11-21 and some versions of old WebKit

I don't see any possible workaround

closes zloirock#764, zloirock#896, zloirock#911
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants