Update to work with ZODB5. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 17, 2016 13:32
By reflecting information gaind when polling. This is important because https://github.com/zopefoundation/ZODB/pull/56/files depends on a working lastTransaction method to set transaction start times.
- Change default for storage sync force to False. - Reduced ths monkey patch in relstorage.__init__.py to work with current ZODB and with ZODB 5. - Changed a test that tested for delayed polling to ignore non-delay under ZODB 5.
The constructor signature for TmpStore changed again. (It's private, dang it.)
jimfulton
pushed a commit
to zopefoundation/ZODB
that referenced
this pull request
May 17, 2016
This and zodb/relstorage#31 make RelStorage pass with this branch (as much as they pass with master).
|
Short review: looks fine. It looks like development/ maintenance of RelStorage is a bit stalled. I'am sure this partly is because its in an organisation where only a few people have write access. Is moving it to zopefoundation repo an option? |
Closed
|
Jens, thanks for the review. That's probably a good idea. I'll see if Shane has any objections. I doubt he will. |
|
Jason, that works for me. Do you want to make a release? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly, this involves fixing lastTransaction, but also includes other tweaks to work (um, tests pass) with ZODB5 (zopefoundation/ZODB#56) and current ZODB.
Note that several tests fail for me on master, likely due to problem in my setup and some change in pickling (probably zodbpickle). These changes neither fix nor make the existing failures worse.