Fixes microsoft#2010 Interpreter link crashes when path variable not set

Checks path variable before adding a variable with no name into the environment.
zooba · Jan 3, 2017 · f7b9ecd · f7b9ecd
1 parent b4d4d0c
commit f7b9ecd
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/Python/Product/PythonTools/PythonTools/InterpreterList/InterpreterListToolWindow.cs b/Python/Product/PythonTools/PythonTools/InterpreterList/InterpreterListToolWindow.cs
@@ -284,16 +284,18 @@ private void StartInterpreter_Executed(object sender, ExecutedRoutedEventArgs e)
                 factory.Configuration.WindowsInterpreterPath;
             psi.WorkingDirectory = factory.Configuration.PrefixPath;
 
-            var provider = _service.KnownProviders.OfType<LoadedProjectInterpreterFactoryProvider>().FirstOrDefault();
-            var vsProject = provider == null ?
-                null :
-                provider.GetProject(factory);
-            var project = vsProject == null ? null : vsProject.GetPythonProject();
-            if (project != null) {
-                psi.EnvironmentVariables[factory.Configuration.PathEnvironmentVariable] = 
-                    string.Join(";", project.GetSearchPaths());
-            } else {
-                psi.EnvironmentVariables[factory.Configuration.PathEnvironmentVariable] = string.Empty;
+            var pathVar = factory.Configuration.PathEnvironmentVariable;
+            if (!string.IsNullOrEmpty(pathVar)) {
+                var provider = _service.KnownProviders.OfType<LoadedProjectInterpreterFactoryProvider>().FirstOrDefault();
+                var vsProject = provider == null ?
+                    null :
+                    provider.GetProject(factory);
+                var project = vsProject == null ? null : vsProject.GetPythonProject();
+                if (project != null) {
+                    psi.EnvironmentVariables[pathVar] = string.Join(";", project.GetSearchPaths());
+                } else {
+                    psi.EnvironmentVariables[pathVar] = string.Empty;
+                }
             }
 
             Process.Start(psi);