Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cleanup #1986

Closed
wants to merge 16 commits into from
Closed

Cleanup #1986

wants to merge 16 commits into from

Conversation

ATorrise
Copy link
Contributor

@ATorrise ATorrise commented Nov 30, 2023

WIP!! - growing into something that needs approval -> developing a write up / proposal to work on this

  • Modifying/updating readmes and creating some standard for package readmes
  • Removing any untouched/unused/ancient code
  • Creating workflow to copy changes from zowe-cli/README.md to zowe-cli/packages/cli/README.md so we only need to edit one file
    • (should maybe change the write access on the later file so that changes don't get lost?)

Amber Torrise and others added 2 commits November 30, 2023 15:03
Signed-off-by: Amber Torrise <at895452@broadcom.net>
Signed-off-by: Amber Torrise <112635587+ATorrise@users.noreply.github.com>
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35a82d7) 91.03% compared to head (aa5bc7d) 91.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1986   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files         635      635           
  Lines       18608    18608           
  Branches     3859     3859           
=======================================
  Hits        16939    16939           
  Misses       1668     1668           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Amber Torrise and others added 11 commits November 30, 2023 15:46
Signed-off-by: Amber Torrise <at895452@broadcom.net>
…c changes in our two cli readmes

Signed-off-by: Amber Torrise <at895452@broadcom.net>
Signed-off-by: Amber Torrise <at895452@broadcom.net>
Signed-off-by: Amber Torrise <at895452@broadcom.net>
Signed-off-by: Amber Torrise <at895452@broadcom.net>
Signed-off-by: Amber Torrise <at895452@broadcom.net>
…d to specify

Signed-off-by: Amber Torrise <at895452@broadcom.net>
Signed-off-by: Amber Torrise <at895452@broadcom.net>
git config --global user.name ${{ secrets.ZOWE_ROBOT_USER }}
git config --global user.email ${{ secrets.ZOWE_ROBOT_EMAIL }}
git add "${{ github.workspace }}/packages/cli/README.md"
git commit -m "Synching cli readmes"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever possible, please make sure to add the -s flag to avoid more missing signoffs 😋

@ATorrise ATorrise linked an issue Dec 1, 2023 that may be closed by this pull request
Signed-off-by: Amber Torrise <at895452@broadcom.net>
Copy link

sonarcloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Signed-off-by: Amber Torrise <112635587+ATorrise@users.noreply.github.com>
Signed-off-by: Amber Torrise <112635587+ATorrise@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
3 participants