-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update tsconfig and web help deps #2215
Conversation
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2215 +/- ##
=======================================
Coverage 91.15% 91.15%
=======================================
Files 638 638
Lines 19103 19103
Branches 3974 4041 +67
=======================================
Hits 17414 17414
Misses 1688 1688
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Timothy for the updates!
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever way to allow the rewriteShrinkwrap.js file to be executed from a different subpackage on the monorepo 😋
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Quality Gate failedFailed conditions |
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
.ts
files instead of.d.ts
filesHow to Test
To test the tsconfig fix:
packages/zosuss/src/SshBaseHandler.ts
).ImperativeError
) and notice a.d.ts
file is opened..ts
file is opened.To test changes to web help, click on links in the doc and verify that active (highlighted) item in tree updates:
Review Checklist
I certify that I have:
Additional Comments