Fix process ID not being reset after event is emitted #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2360 +/- ##
========================================
Coverage 91.27% 91.27%
========================================
Files 636 636
Lines 18068 18071 +3
Branches 3895 3787 -108
========================================
+ Hits 16491 16494 +3
Misses 1576 1576
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
t1m0thyj
changed the title
t1m0thyj
requested review from
anaxceron,
ATorrise,
gejohnston,
zFernand0,
awharn,
pujal0909,
traeok and
jace-roell
Open
15 tasks
traeok
approved these changes
Nov 13, 2024
Comment on lines
+208
to
+211
| let shouldProcessEvent = eeInst.eventTimes.get(eventName) !== event.eventTime; | ||
| eeInst.eventTimes.set(eventName, event.eventTime); | ||
| // Checks that event was not triggered by the same process | ||
| shouldProcessEvent &&= process.pid !== event.appProcId; |
There was a problem hiding this comment.
Could lines 208 and 211 be combined? Combining the lines will also allow you to use const instead of let:
const shouldProcessEvent = eeInst.eventTimes.get(eventName) !== event.eventTime && process.pid !== event.appProcId;`
gejohnston
approved these changes
Nov 13, 2024
anaxceron
approved these changes
Nov 13, 2024
|
t1m0thyj
added
the
release-patch
|
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
This fixes a regression of #2323 where after the
onVaultChangedevent was ignored because of same process ID, then subsequentonVaultChangedevents from external apps would be ignored.Also updates the
cross-spawnpackage for technical currency.How to Test
Review Checklist
I certify that I have:
Additional Comments