Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Group common methods into Singleton classes #2109

Closed
Tracked by #2275 ...
zFernand0 opened this issue Feb 2, 2023 · 3 comments
Closed
Tracked by #2275 ...

Group common methods into Singleton classes #2109

zFernand0 opened this issue Feb 2, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request priority-medium Not functioning - next quarter if capacity permits Technical Debt Includes Architecture, Code, Testing, Automation debt v3

Comments

@zFernand0
Copy link
Member

zFernand0 commented Feb 2, 2023

Is your feature request related to a problem? Please describe.

In an effort to reduce the maintenance efforts of Zowe Explorer, it might be convenient to group related methods under a single class. This should help streamline how imports are handled when developing new features and how tests are written for these new methods.

Describe the solution you'd like

Ideally we will use singleton classes 😋

Describe alternatives you've considered

We can consider using:

  • Classes with static methods: may have its own drawbacks (not all of which may apply in our case)
  • Namespaces: may cause issues when writing jest-tests for method that are not explicitly exported (medium)

Additional context

Suggestion:

@zFernand0 zFernand0 added the enhancement New feature or request label Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Thank you for raising this issue.
The community has 90 days to upvote 👍 the issue.
If it receives 10 upvotes, we will move it to our backlog. If not, we will close it.

@zFernand0 zFernand0 added Technical Debt Includes Architecture, Code, Testing, Automation debt priority-medium Not functioning - next quarter if capacity permits v3 labels Feb 2, 2023
@JillieBeanSim JillieBeanSim mentioned this issue Mar 27, 2023
27 tasks
@zFernand0 zFernand0 added this to the vNext milestone Apr 25, 2023
@zFernand0
Copy link
Member Author

We could address this comment at the same time we handle this issue. 😋

@JillieBeanSim JillieBeanSim mentioned this issue Jun 27, 2023
29 tasks
@JillieBeanSim JillieBeanSim removed this from the vNext milestone Aug 25, 2023
@JillieBeanSim JillieBeanSim mentioned this issue Sep 25, 2023
31 tasks
@rudyflores rudyflores self-assigned this Oct 30, 2023
@t1m0thyj t1m0thyj moved this from New Issues to Medium Priority in Zowe Explorer for VS Code Dec 26, 2023
@t1m0thyj t1m0thyj moved this from Medium Priority to PI Backlog in Zowe Explorer for VS Code Dec 26, 2023
@JillieBeanSim
Copy link
Contributor

Closing with the merge of #2698

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request priority-medium Not functioning - next quarter if capacity permits Technical Debt Includes Architecture, Code, Testing, Automation debt v3
Projects
None yet
Development

No branches or pull requests

3 participants