Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[vNext] remove v1 profiles support #2244

Merged
merged 8 commits into from
May 23, 2023
Merged

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Apr 24, 2023

Proposed changes

This PR removes the v1 Profile support

New Issues opened as followup tech debt/enhancements:
Theia tests to run with team config file
Add profiles convert to team config capability

Release Notes

Milestone: v3 Pre-release

Changelog: Removed v1 Profile support.

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@JillieBeanSim JillieBeanSim self-assigned this Apr 24, 2023
@JillieBeanSim JillieBeanSim changed the base branch from main to next April 24, 2023 11:47
@JillieBeanSim JillieBeanSim linked an issue Apr 24, 2023 that may be closed by this pull request
@JillieBeanSim JillieBeanSim added this to the vNext milestone Apr 24, 2023
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 90.62% and project coverage change: +0.96 🎉

Comparison is base (fd99566) 90.71% compared to head (e9b780d) 91.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2244      +/-   ##
==========================================
+ Coverage   90.71%   91.67%   +0.96%     
==========================================
  Files          86       90       +4     
  Lines        8052     8541     +489     
  Branches     1697     1727      +30     
==========================================
+ Hits         7304     7830     +526     
+ Misses        747      710      -37     
  Partials        1        1              
Impacted Files Coverage Δ
...ckages/zowe-explorer-api/src/logger/IZoweLogger.ts 100.00% <ø> (ø)
packages/zowe-explorer-api/src/tree/IZoweTree.ts 100.00% <ø> (ø)
packages/zowe-explorer/src/uss/USSTree.ts 93.16% <ø> (+0.78%) ⬆️
packages/zowe-explorer/src/uss/ZoweUSSNode.ts 93.99% <ø> (-1.44%) ⬇️
packages/zowe-explorer/src/uss/actions.ts 90.72% <ø> (+1.37%) ⬆️
packages/zowe-explorer/src/uss/init.ts 99.13% <ø> (-0.87%) ⬇️
packages/zowe-explorer/src/uss/utils.ts 90.47% <ø> (+2.24%) ⬆️
...ges/zowe-explorer/src/utils/DecorationProviders.ts 100.00% <ø> (ø)
packages/zowe-explorer/src/utils/LoggerUtils.ts 100.00% <ø> (ø)
packages/zowe-explorer/src/utils/ProfilesUtils.ts 87.71% <ø> (+1.04%) ⬆️
... and 46 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@JillieBeanSim JillieBeanSim marked this pull request as ready for review May 17, 2023 11:50
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
Thanks for opening the follow-up issues

packages/zowe-explorer/src/job/ZosJobsProvider.ts Outdated Show resolved Hide resolved
packages/zowe-explorer/src/utils/ProfilesUtils.ts Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @JillieBeanSim

Should we remove the "Delete Profile" option, or update it for v2 session nodes? Seems like "Delete Profile" functions the same as "Update Profile" in its current state.

@JillieBeanSim JillieBeanSim merged commit a462812 into next May 23, 2023
@JillieBeanSim JillieBeanSim deleted the vNext/remove-v1-profiles branch May 23, 2023 11:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3] Remove v1 profile support
3 participants