-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Allow users to contribute translations with POEditor #2894
Conversation
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2894 +/- ##
=======================================
Coverage 93.40% 93.40%
=======================================
Files 121 121
Lines 10834 10835 +1
Branches 2280 2232 -48
=======================================
+ Hits 10119 10120 +1
Misses 713 713
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
😻Love this enhancement😻 |
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
e9d0e2d
to
3758d32
Compare
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done -- thank you @t1m0thyj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @t1m0thyj, this will make it a lot easier to contribute ZE translations moving forward 😋
LGTM - tested on Windows and the script works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! 😋
I do have one small change that might need to be addressed😋
Proposed changes
Created a POEditor project where users can contribute translations. Added two dev scripts:
scripts/generatePoeditorJson.js
- Generates l10n json file in a format that can be imported into POEditorscripts/downloadPoeditorL10n.js
- Downloads user-contributed translations in a format that can be bundled in VSIXTo maintain these translations going forward:
This PR also cleans up some redundant localization strings and fixes an issue where the string "Favorites" was not always being localized which could cause ZE activation to fail.
TODO:
{0}
and{1}
Release Notes
Milestone: v3
Changelog: N/A
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments