-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove inconsistency in translation strings #3272
Conversation
Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
📅 Suggested merge-by date: 11/19/2024 |
Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
Hi @likhithanimma1 -- I was just curious about how we decided what to capitalize and what to not capitalize. I'd like to make sure we're capitalizing proper nouns or key concepts only. |
Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3272 +/- ##
=======================================
Coverage 93.08% 93.08%
=======================================
Files 114 114
Lines 11825 11825
Branches 2684 2684
=======================================
Hits 11007 11007
Misses 816 816
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR LGTM as-is (IFF that's what we want to do) 😋
I'd love to get someone from the Docs Squad to review this PR just to confirm that we are being consistent across Zowe 😅
"Tag": "Tag", | ||
"Owner": "Owner", | ||
"Apply changes": "Apply changes", | ||
"The API does not support updating attributes for this": "The API does not support updating attributes for this", | ||
"Waiting for data from extension...": "Waiting for data from extension...", | ||
"Log in to Authentication Service": "Log in to Authentication Service", | ||
"Select a certificate and certificate key in PEM format:": "Select a certificate and certificate key in PEM format:", | ||
"Select a certificate and Certificate Key in PEM format:": "Select a certificate and Certificate Key in PEM format:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why we capitalize Certificate Key and not Certificate 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I'm sold on capitalizing each word in the strings, considering that we often don't capitalize every word in a header or similar short-form text (input areas, help-text) that make their way to end-users.
Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @likhithanimma1 for making the ZE interface more consistent! 🎉
After this PR is merged, I can upload the new automatic translations from Artifactory to POEditor 😋
Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
111b8fa
Proposed changes
This PR mainly addresses the issue #2935 to remove inconsistency in translation strings
Release Notes
Milestone:
Changelog:
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments