Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove inconsistency in translation strings #3272

Merged
merged 14 commits into from
Nov 6, 2024
Merged

Conversation

likhithanimma1
Copy link
Contributor

Proposed changes

This PR mainly addresses the issue #2935 to remove inconsistency in translation strings

Release Notes

Milestone:

Changelog:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
@likhithanimma1 likhithanimma1 marked this pull request as draft October 23, 2024 06:35
Copy link

github-actions bot commented Oct 23, 2024

📅 Suggested merge-by date: 11/19/2024

Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
@anaxceron
Copy link
Contributor

Hi @likhithanimma1 -- I was just curious about how we decided what to capitalize and what to not capitalize. I'd like to make sure we're capitalizing proper nouns or key concepts only.

Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.08%. Comparing base (816d270) to head (111b8fa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...es/zowe-explorer/src/commands/TsoCommandHandler.ts 33.33% 2 Missing ⚠️
...ckages/zowe-explorer/src/configuration/Profiles.ts 90.00% 1 Missing ⚠️
packages/zowe-explorer/src/utils/ProfilesUtils.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3272   +/-   ##
=======================================
  Coverage   93.08%   93.08%           
=======================================
  Files         114      114           
  Lines       11825    11825           
  Branches     2684     2684           
=======================================
  Hits        11007    11007           
  Misses        816      816           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR LGTM as-is (IFF that's what we want to do) 😋

I'd love to get someone from the Docs Squad to review this PR just to confirm that we are being consistent across Zowe 😅

"Tag": "Tag",
"Owner": "Owner",
"Apply changes": "Apply changes",
"The API does not support updating attributes for this": "The API does not support updating attributes for this",
"Waiting for data from extension...": "Waiting for data from extension...",
"Log in to Authentication Service": "Log in to Authentication Service",
"Select a certificate and certificate key in PEM format:": "Select a certificate and certificate key in PEM format:",
"Select a certificate and Certificate Key in PEM format:": "Select a certificate and Certificate Key in PEM format:",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why we capitalize Certificate Key and not Certificate 😋

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I'm sold on capitalizing each word in the strings, considering that we often don't capitalize every word in a header or similar short-form text (input areas, help-text) that make their way to end-users.

Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
@likhithanimma1 likhithanimma1 marked this pull request as ready for review November 5, 2024 14:58
Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com>
JillieBeanSim
JillieBeanSim previously approved these changes Nov 5, 2024
t1m0thyj
t1m0thyj previously approved these changes Nov 5, 2024
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @likhithanimma1 for making the ZE interface more consistent! 🎉

After this PR is merged, I can upload the new automatic translations from Artifactory to POEditor 😋

anaxceron
anaxceron previously approved these changes Nov 5, 2024
Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
@JillieBeanSim JillieBeanSim merged commit b1de4d1 into main Nov 6, 2024
24 of 25 checks passed
@JillieBeanSim JillieBeanSim deleted the fix/translationstrings branch November 6, 2024 13:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

5 participants