refactor: Adjust "Add to Workspace" labels and fetch resources for external URLs

[traeok]

Proposed changes

Refactors a couple things from work recently merged in (#3282 and #3271)

• Adjust labels to be consistent regardless of item added to workspace
• Do a remote lookup of resource before opening it

Release Notes

Milestone: 3.1.0

Changelog:

No changelog since feature hasn't been released yet.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.09%. Comparing base (b1de4d1) to head (b0aaf8e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3288      +/-   ##
==========================================
+ Coverage   93.08%   93.09%   +0.01%     
==========================================
  Files         114      114              
  Lines       11825    11834       +9     
  Branches     2570     2568       -2     
==========================================
+ Hits        11007    11017      +10     
+ Misses        816      815       -1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📅 Suggested merge-by date: 11/14/2024

[zFernand0]

LGTM! 😋

I love the consistency

---

Side note:

Sorry to be picky, but should we make the "missing-path" message consistent (or at least more clear for adding things to as favorites?

[traeok]

Sorry to be picky, but should we make the "missing-path" message consistent (or at least more clear for adding things to as favorites?

Honestly, I'm not sure why we even have this string in place. I looked at filterPrompt and it seems we don't validate input, rather that we show this message if an empty path was entered. This doesn't seem very conducive to a good UX - if we had input validation in place, then users would have to provide a non-empty path to continue, and then this scenario wouldn't be encountered.

I refactored this logic so that it looks for a valid path before the input box can be submitted:

If the dialog is dismissed, the input box exits as expected and the operation is cancelled. It's not really related to this work, but the current UX is a bit annoying, so I figured I might as well fix it.

[t1m0thyj]

LGTM, thanks @traeok!

[JillieBeanSim]

Thanks @traeok LGTM