Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upload test results in CI when there are failing tests #3322

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Nov 15, 2024

Proposed changes

This is useful for debugging integration tests since we can download screenshots of failing tests 😋

Also hopefully fixes transient errors on the ShowConfigErrorDialog test - since sometimes notifications are hidden in the notification center and other times they are still visible, it seems like we need to check both places.

Release Notes

Milestone: N/A

Changelog: N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.99%. Comparing base (7143336) to head (2c17edf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3322   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files         116      116           
  Lines       12069    12069           
  Branches     2738     2781   +43     
=======================================
  Hits        11224    11224           
  Misses        843      843           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj added the no-changelog Add to PR's that don't require a CHANGELOG update label Nov 15, 2024
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Copy link

📅 Suggested merge-by date: 11/29/2024

@t1m0thyj
Copy link
Member Author

There is another integration test (UpdateCredentials.feature) that has frequent transient failures, marking as draft until this one is fixed.

@t1m0thyj t1m0thyj marked this pull request as draft November 15, 2024 20:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update size/S
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant