Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

manifest sourceDep check worflow #3806

Merged
merged 14 commits into from
Apr 18, 2024

Conversation

MarkAckert
Copy link
Member

@MarkAckert MarkAckert commented Apr 17, 2024

This PR adds a new workflow which will help detect sourceDependencies errors in the manifest.json.template. These errors were usually uncaught until RC branches where the sourceDependencies section becomes picked up by other automation, and as such the errors were always slow to find.

The idea is to validate sourceDependencies early, and check every repo+tag entry as both as a tag and a branch, since other automation can tolerate either. By convention, sourceDependencies for RC and release branches should be tags or commit hashes which pin down a specific build, so this automation's behavior will be stricter for PRs against RC/Main/Master branches.

This PR edited the following sourceDependencies sections from the manifest:

  • Removed imperative. This should've been deleted already but found its way back in. Covered in zowe-cli repo
  • Updated orion-editor-component. the master branch was deleted, v2.x/master was created.

Test:

Against v2.x/staging with old orion branch. Expected=FAIL, Actual=FAIL.
Against v2.x/staging. Expected=PASS, Actual=PASS.
Against v2.x/rc: Expected=FAIL, Actual= FAIL (local test)
Against v2.x/master: Expected=FAIL, Actual= FAIL (local test)
Against v3.x/rc: Expected=FAIL, Actual= FAIL (local test)

Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
@MarkAckert MarkAckert assigned struga0258 and unassigned struga0258 Apr 17, 2024
@MarkAckert MarkAckert requested a review from struga0258 April 17, 2024 20:03
Copy link

github-actions bot commented Apr 17, 2024

build 5082 CANCELLED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/8728048330

@MarkAckert MarkAckert added Build: None Used in CI Build: PAX Used in CI Test: None Used in CI and removed Build: None Used in CI labels Apr 17, 2024
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Copy link

github-actions bot commented Apr 17, 2024

build 5083 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/8728152906

Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Copy link

github-actions bot commented Apr 17, 2024

build 5084 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/8728176305

Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Copy link

github-actions bot commented Apr 17, 2024

build 5086 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/8728278676

@MarkAckert MarkAckert added Build: None Used in CI and removed Build: PAX Used in CI labels Apr 17, 2024
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
@MarkAckert MarkAckert changed the base branch from v2.x/staging to v2.x/rc April 18, 2024 16:35
@MarkAckert MarkAckert changed the title First draft - manifest sourceDep check worflow manifest sourceDep check worflow Apr 18, 2024
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
@MarkAckert MarkAckert changed the base branch from v2.x/rc to v2.x/staging April 18, 2024 16:38
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
@MarkAckert MarkAckert merged commit 2d56f3e into v2.x/staging Apr 18, 2024
7 checks passed
@MarkAckert MarkAckert deleted the user/markackert/manifest-automate branch April 18, 2024 16:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Build: None Used in CI Test: None Used in CI
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants