-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
manifest sourceDep check worflow #3806
Conversation
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
build 5082 CANCELLED. |
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
build 5083 SUCCEEDED. |
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
build 5084 SUCCEEDED. |
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
build 5086 SUCCEEDED. |
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
This PR adds a new workflow which will help detect
sourceDependencies
errors in the manifest.json.template. These errors were usually uncaught until RC branches where thesourceDependencies
section becomes picked up by other automation, and as such the errors were always slow to find.The idea is to validate sourceDependencies early, and check every repo+tag entry as both as a
tag
and abranch
, since other automation can tolerate either. By convention, sourceDependencies for RC and release branches should be tags or commit hashes which pin down a specific build, so this automation's behavior will be stricter for PRs against RC/Main/Master branches.This PR edited the following
sourceDependencies
sections from the manifest:master
branch was deleted,v2.x/master
was created.Test:
Against v2.x/staging with old orion branch. Expected=FAIL, Actual=FAIL.
Against v2.x/staging. Expected=PASS, Actual=PASS.
Against v2.x/rc: Expected=FAIL, Actual= FAIL (local test)
Against v2.x/master: Expected=FAIL, Actual= FAIL (local test)
Against v3.x/rc: Expected=FAIL, Actual= FAIL (local test)