Merge pull request #44 from zulfikarrosadi/fix/products-update

Fix/products update
zulfikarrosadi · Nov 21, 2024 · 831f67f · 831f67f
2 parents 2db640e + 8767f01
commit 831f67f
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/src/product/service.ts b/src/product/service.ts
@@ -151,8 +151,8 @@ class ProductService {
     id: string,
     data: UpdateProductDataService,
   ): Promise<ApiResponse<Product>> => {
-    const parsedId = BigInt(id)
     try {
+      const parsedId = BigInt(id)
       if (Number.isNaN(parsedId)) {
         throw new NotFoundError(
           "you are trying to update the product that doesn't exists",
@@ -197,6 +197,15 @@ class ProductService {
         'updateProductById',
         context,
       )
+      if (error instanceof SyntaxError) {
+        return {
+          status: 'fail',
+          errors: {
+            code: 404,
+            message: 'fail to update product, product not found',
+          },
+        }
+      }
       return {
         status: 'fail',
         errors: {