Skip to content

test: Fix new action-sheet tests #244

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2023
Merged

test: Fix new action-sheet tests #244

merged 1 commit into from
Aug 1, 2023

Conversation

chrisbobbe
Copy link
Collaborator

Like 38ed6c8, but for some tests that were still in PR-flight at the time and so didn't get that treatment.

@chrisbobbe
test: Fix new action-sheet tests
593f538 
Like 38ed6c8, but for some tests that were still in PR-flight at
the time and so didn't get that treatment.
@chrisbobbe chrisbobbe requested a review from gnprice August 1, 2023 00:52
@chrisbobbe
Copy link
Collaborator Author

Discussion: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.3A.20Failing.20tests/near/1618345

@gnprice
Copy link
Member

gnprice commented Aug 1, 2023

Ah, thanks for catching this! Merging.

Chalk another one up for pinning the Flutter version, #15 — I'd actually run the tests before merging #213 (because I'd rebased the commits), but was on an older Flutter version.

@gnprice gnprice merged commit 593f538 into zulip:main Aug 1, 2023
@chrisbobbe chrisbobbe deleted the pr-fix-tests-again branch August 1, 2023 05:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@gnprice gnprice Awaiting requested review from gnprice

Assignees
No one assigned
Labels
a-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisbobbe @gnprice