Skip to content

deps: Flutter, packages, and fix macos/Podfile.lock #319

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented Oct 16, 2023

deps: Run pod update sqlite3 in macos/

This is necessary for flutter run to work on a macOS target,
presumably since 5dbf1e6.

Similar to c5c0949 and 105727e for a previous upgrade.
The symptoms were just like those described in the latter commit.


deps: Upgrade Flutter to latest main, 3.16.0-11.0.pre.88

And update Flutter's supporting libraries to match.


deps: Upgrade packages within constraints (flutter pub upgrade)

Plus flutter build ios --config-only
and flutter build macos --config-only.


deps: Upgrade packages to latest, namely file_picker

This is the result of flutter pub upgrade --major-versions,
followed by flutter build ios --config-only.
(Plus flutter build macos --config-only, but it has no
effect, as file_picker doesn't appear in macos/Podfile.lock .)

Changelog:
https://pub.dev/packages/file_picker/changelog

The API changes don't affect our usage.

@gnprice
Copy link
Member Author

gnprice commented Oct 16, 2023

Added one more commit at the start:

deps: Update CocoaPods to 1.13.0

This is needed on Xcode 15, at least once certain packages are
pulled in.  (In particular, firebase_core, which I have in a
draft branch for handling notifications.)

Upstream issue thread:
  https://github.com/CocoaPods/CocoaPods/pull/12009

@chrisbobbe
Copy link
Collaborator

deps: Run pod update sqlite3 in macos/

Ah hmm, yeah; I think I remember doing this in ios/ but I don't remember doing it in macos/. I wonder how easy it would be to add checks for this in CI.

gnprice and others added 5 commits October 18, 2023 16:46
This is needed on Xcode 15, at least once certain packages are
pulled in.  (In particular, firebase_core, which I have in a
draft branch for handling notifications.)

Upstream issue thread:
  CocoaPods/CocoaPods#12009
This is necessary for `flutter run` to work on a macOS target,
presumably since 5dbf1e6.

Similar to c5c0949 and 105727e for a previous upgrade.
The symptoms were just like those described in the latter commit.
And update Flutter's supporting libraries to match.
Plus `flutter build ios --config-only`
and `flutter build macos --config-only`.
This is the result of `flutter pub upgrade --major-versions`,
followed by `flutter build ios --config-only`.
(Plus `flutter build macos --config-only`, but it has no
effect, as file_picker doesn't appear in macos/Podfile.lock .)

Changelog:
  https://pub.dev/packages/file_picker/changelog

The API changes don't affect our usage.
@chrisbobbe chrisbobbe merged commit e4e5705 into zulip:main Oct 18, 2023
@chrisbobbe
Copy link
Collaborator

Thanks, LGTM! Merged.

@gnprice gnprice deleted the pr-deps branch October 18, 2023 21:19
@gnprice
Copy link
Member Author

gnprice commented Oct 18, 2023

I wonder how easy it would be to add checks for this in CI.

Yeah. GitHub does offer macOS-based runners for actions:
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

There's a steep 10x multiplier in how they count against our quota of free usage (and a similar steeper rate if paying for more):
https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions#minute-multipliers
so we'll want to stick to Linux for all the suites where we can, but that shouldn't stop us from using macOS where necessary.

I'll file an issue. → #329

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants