Skip to content

Warning message before unsubscribing from streams #5578

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arijitghosal03
Copy link

An alert has been added when user wises to unsubscribe from a stream.
Changes made in StreamScreenSettings.js

An alert has been added when user wises to unsubscribe from a stream
@gnprice
Copy link
Member

gnprice commented Dec 2, 2022

Thanks for the contribution.

It sounds like this is intended for #5553. Do mention the issue in the PR and commit; see style guide for details:
https://github.com/zulip/zulip-mobile/blob/main/docs/style.md#github

There are a bunch of extraneous changes in this commit, mostly adding extra files. See our guidance on clear and coherent commits:
https://zulip.readthedocs.io/en/latest/contributing/version-control.html
and take a look at our Git guide:
https://github.com/zulip/zulip-mobile/blob/main/docs/howto/git.md

@chrisbobbe
Copy link
Contributor

Also, have you tested this manually, and does it work as you intend it to? Please also be sure to do that. Thanks! 🙂

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants