-
-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
allow packaging and running from a wheel #780
base: main
Are you sure you want to change the base?
allow packaging and running from a wheel #780
Conversation
…heel I don't have much experience with python packaging, but i used 'UV' and let the output of `uv build --python 3.11` guide me
just realised that the versions in requirements.txt are pinned now, will fix it when i have time |
Don’t know if it’s possible, but an update script would be kinda nice(if installed from path). I mean it could probably resolve its path from the installed item in the venv to the path on the hard drive. Run got fetch to check for updates. If it found something it could run git pull & reinstall itself. |
ideally the packaged app would go on pypi and we'd just let pip handle installation/updates |
I doubt that every change will be published tho. Installing it as a wheel locally would allow the install to be easier as the depencies will be downloaded automatically & it works as a command or am I wrong, but the published version will probably always be a few months behind(being somewhat stable and all) That’s why I suggested the local update script. If the source can be detected it could just pip update if needed. I doubt that that would be the issue. Would be quite nice if it could detect if it’s from web or local. |
FYI I think this block is not really used now. Till months ago there was a unmaintained poetry-based configuration which may used deps in the toml . It got removed in #708 . |
Im a fan of the idea, the script could also remove the need for a pip wheel. We could let the wrapper handle pulling the code and running |
why all the code format changes? |
Sorry, I've been meaning to clean that up but busy with work. Will get rid of the unrelated changes this afternoon. |
for context, I used ran ruff's linter and most of the changes are getting rid of imports or turning I think I'd prefer going with @frederik-uni 's idea. A script that handles pulling the repo, setting up deps, and making sure its up to date might be a better solution. |
I had to move the fonts into the
manga_translator
package, which is the recommended approachI don't have much experience with python packaging, but i used UV and let the output of
uv build --python 3.11
guide me.A lot of these changes might not be necassery, the main one that comes to mind is the removal of relative imports in a few of the top level files.
The
dependencies
block in pyproject.toml currently includes the cuda version of pytorch, it'd be good if the different versions were listed under optional dependencies