Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Merge @mikecunha's additions #16

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Merge @mikecunha's additions #16

wants to merge 11 commits into from

Conversation

KOLANICH
Copy link

No description provided.

michael.cunha added 11 commits February 20, 2018 19:57
ignore moar things
3d3a3ae
Update to Python 3
41234cb 
Using 2to3.
Update to Python 3
e0a17f1 
Using 2to3. Also cleaned up white space formatting.
Update to Python 3
5f577d0 
Using 2to3.
Update to Python 3
940acd7 
Using 2to3.
Update to Python 3
b216056 
Using 2to3.
Update to Python 3
a352056
Update to Python 3
6b4fa98
Update to Python 3
8d4414f
Callout original repo
40fc034
Restructure into installable package
032478f 
Base functionality works after a python setup.py install now. However,
none of the defs that attempt to import csv files from the data
directory work with this commit. It will need a MANIFEST.in and/or
package_data and some work with relative paths.
@KOLANICH KOLANICH changed the title Merge mikecunhas' additions Merge @mikecunha's additions Aug 15, 2018
@shlicshlac
Copy link

Why did you propose typecasting dict.items() calls to lists everywhere?

@KOLANICH
Copy link
Author

  1. I am not the original author of the code
  2. It is a modification 2to3 does. The automatic way to port python 2 code to python 3 is to run 2to3. It is not very intelligent, so it wraps the funcs returning iterators in python 3 that have been returning lists in python 2 into lists.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KOLANICH @shlicshlac