Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make it possible to run command line interaction together with UI. #4

Open
wants to merge 2 commits into
base: asyncli
Choose a base branch
from

Conversation

kramlie
Copy link

@kramlie kramlie commented Dec 14, 2024

This is just a port of what has already been done for GTK and Qt.

@kramlie
Copy link
Author

kramlie commented Dec 14, 2024

@jofemodo: I hope this can be considered for Zynthian!

This goes together with zynthian/zynthian-ui#507.

@jofemodo
Copy link
Member

jofemodo commented Feb 4, 2025

Hi @kramlie !

This needs to be rebased against the asyncli branch to work with the latest version.

Thanks

@jofemodo jofemodo changed the base branch from master to asyncli February 4, 2025 09:56
@kramlie
Copy link
Author

kramlie commented Feb 4, 2025

Hey @jofemodo!

Looks like there is a conflicting implementation of the same thing in the asyncli branch, but it doesn't work correctly. I will need a bit of time to figure that out and fix it. Unless you are planning to look at it yourself?

The symptom is that when using the jalv -s option to enable the GUI, the command line interface stops working. In my original implementation the command line and GUI could respond at the same time.

Signed-off-by: Kristian Amlie <kristian@amlie.name>
After 0991714 it is possible to start the command line thread
separately from the UI, it just didn't check for this condition
upon starting. By splitting the two checks we allow for both the
command line and graphical interface to be accessible at the same
time.

Signed-off-by: Kristian Amlie <kristian@amlie.name>
@kramlie
Copy link
Author

kramlie commented Feb 5, 2025

Alright, @jofemodo, luckily this turned out to be a pretty small fix. All the pieces were there, it just didn't check the flags correctly when starting. I have now updated so it can be merged to the asyncli branch!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants