Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix sdba Grouper.get_coordinate after xarray update #2038

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Uses a dumber way of getting the max doy, that doesn't rely on a private xarray function. There is a public xarray function in >=2024.09, but we still support >=2023.11.

Does this PR introduce a breaking change?

Yes, only if a non-uniform calendar was used with a subset of years that did not include a leap year. The max doy is now static (standard => 366, for example) and not dynamic (standard, 2004 => 366).

@github-actions github-actions bot added the sdba Issues concerning the sdba submodule. label Jan 8, 2025
@github-actions github-actions bot added the approved Approved for additional tests label Jan 15, 2025
@coveralls
Copy link

Coverage Status

coverage: 89.962%. remained the same
when pulling f217d13 on fix-Grouper-360
into e34df04 on main.

@aulemahal aulemahal merged commit 35694f8 into main Jan 16, 2025
36 checks passed
@aulemahal aulemahal deleted the fix-Grouper-360 branch January 16, 2025 15:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Approved for additional tests sdba Issues concerning the sdba submodule.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adapt_freq broken with 360_day and group 31-doy
3 participants