refactor: ♻️ Use typing_extensions.deprecated instead of own implementation
#2655
+62
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Dorukyum
reviewed
Jan 31, 2025
| @@ -340,12 +375,11 @@ def deprecated( | |||
| since: str | None = None, | |||
| removed: str | None = None, | |||
| reference: str | None = None, | |||
| stacklevel: int = 3, | |||
| stacklevel: int = 1, | |||
There was a problem hiding this comment.
Typing's thing for some reason changes the levels in some way and to keep a correct stacktrace I had to change it. Admittedly I just tried and see.
Signed-off-by: Paillat <me@paillat.dev>
|
Could smbd rerun readthedocs pls ? |
|
Done |
Paillat-dev
commented
Mar 12, 2025
| ) -> Callable[[Callable[[P], T]], Callable[[P], T]]: | ||
| """A decorator implementation of :func:`warn_deprecated`. This will automatically call :func:`warn_deprecated` when | ||
| the decorated function is called. | ||
| ) -> _typing_deprecated: |
There was a problem hiding this comment.
I should test if this is actually detected correctly by type checkers
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Information
fixes: Update utils.deprecated to use PEP 702 #1917
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.