Fix issue #22 - conda-env-kernel-image example is broken #26
Conversation
Fix issue #22 - conda-env-kernel-image example is broken
| "FileSystemConfig": { | ||
| "MountPath": "/root", | ||
| "MountPath": "/home/sagemaker-user", | ||
| "DefaultUid": 0, | ||
| "DefaultGid": 0 |
There was a problem hiding this comment.
https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_FileSystemConfig.html
why change MounPath. It appears user inside the container is still root
There was a problem hiding this comment.
If you leave it root, than it will fail to mount.
There was a problem hiding this comment.
I tested with existing config and kerne launch succeeded without this change. can you drop this change?
There was a problem hiding this comment.
Reverted to "MountPath": "/root",, tested it on my Studio domain and it worked.
Pushed changes.
| @@ -3,12 +3,12 @@ | |||
| "KernelGatewayImageConfig": { | |||
| "KernelSpecs": [ | |||
| { | |||
| "Name": "conda-env-myenv-py", | |||
| "Name": "python3", | |||
There was a problem hiding this comment.
super confused, how did it ever work before
There was a problem hiding this comment.
It must be python3 so this is a good question...
There was a problem hiding this comment.
I got similar working correctly this week (conda-env-mycoolenv-py) - I believe this is the auto-detection mentioned in "Kernel discovery" section of the custom image spec? I logged docs feedback that they should clarify there what the "Name"s are for auto-detected conda environments.
I believe this is something that SageMaker or jupyter_kernel_gateway is doing? Because as discussed here seems like auto-setup of conda envs as Jupyter kernels is not automatic from conda itself?
| RUN conda env create -f environment.yml | ||
| RUN conda env update -f environment.yml --prune |
There was a problem hiding this comment.
sry missed this earlier. Why do we need this change? what is prune trying to achieve?
There was a problem hiding this comment.
In the original sample, this iwll create a new conda environment called myenv. Then, since base environment is being selected by default in Studio, so how do you switch to myenv conda?
With this change, I override the base environment, which is selected by default by Studio.
Issue #, if available:
#22
Description of changes:
Fix conda-env-kernel-image example is broken issue:
basecondaenvironment instead of creating a newmyenvone.python3, as the one on Image.MountPathto be/home/sagemaker-user.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.