-
Notifications
You must be signed in to change notification settings - Fork 88
Fix issue #22 - conda-env-kernel-image example is broken #26
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Changes from all commits
d4f0209
85f3031
bcfadda
f630b97
8b32c8f
aa7c5d8
0853327
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
|
||
examples/conda-env-kernel-image/.idea/conda-env-kernel-image.iml | ||
examples/conda-env-kernel-image/.idea/inspectionProfiles/profiles_settings.xml | ||
examples/conda-env-kernel-image/.idea/modules.xml | ||
examples/conda-env-kernel-image/.idea/vcs.xml |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
FROM continuumio/miniconda3:4.9.2 | ||
|
||
COPY environment.yml . | ||
RUN conda env create -f environment.yml | ||
RUN conda env update -f environment.yml --prune | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ | |
"KernelGatewayImageConfig": { | ||
"KernelSpecs": [ | ||
{ | ||
"Name": "conda-env-myenv-py", | ||
"Name": "python3", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. super confused, how did it ever work before There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It must be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I got similar working correctly this week ( I believe this is something that SageMaker or |
||
"DisplayName": "Python [conda env: myenv]" | ||
} | ||
], | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
name: myenv | ||
name: base | ||
channels: | ||
- conda-forge | ||
dependencies: | ||
- python=3.8 | ||
- python=3.9 | ||
- numpy | ||
- awscli | ||
- boto3 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sry missed this earlier. Why do we need this change? what is prune trying to achieve?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the original sample, this iwll create a new conda environment called
myenv
. Then, sincebase
environment is being selected by default in Studio, so how do you switch tomyenv
conda?With this change, I override the
base
environment, which is selected by default by Studio.