Skip to content

Add mypy-plugin extras to allow proper mypy version when using mypy plugin #483

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhukovgreen
Copy link

@zhukovgreen zhukovgreen commented Mar 16, 2023

Fixes #481

Can be merged after

I have made things!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Related issues

🙏 Please, if you or your company finds dry-python valuable, help us sustain the project by sponsoring it transparently on https://github.com/sponsors/dry-python. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.

@zhukovgreen zhukovgreen force-pushed the fix/ensure-compatible-mypy-version branch from 4050e2a to 322d21b Compare March 17, 2023 12:41
@zhukovgreen zhukovgreen changed the title Pin mypy version to ensure correct work of the mypy plugin Add mypy-plugin extras to allow proper mypy version when using mypy plugin Mar 17, 2023
@zhukovgreen zhukovgreen force-pushed the fix/ensure-compatible-mypy-version branch from 4fc5b66 to 7c03515 Compare April 26, 2023 08:57
@zhukovgreen zhukovgreen force-pushed the fix/ensure-compatible-mypy-version branch from 7c03515 to b73cdf2 Compare April 26, 2023 16:47
@eineruntervielen
Copy link

i encountered this problem last night. i adore your library. is their anything still open or why is this issue not merged yet?
all the best, erik

@sobolevn
Copy link
Member

Yes, we need to merge #487 first

@zhukovgreen zhukovgreen force-pushed the fix/ensure-compatible-mypy-version branch from b73cdf2 to 24ad2e4 Compare June 23, 2023 12:14
use `pip install classes[mypy-plugin]` for installin additional
dependencies required by the mypy-plugin.
Add mypy-plugin extra dependency

use `pip install classes[mypy-plugin]` for installing additional
dependencies required by the mypy-plugin.
@zhukovgreen zhukovgreen force-pushed the fix/ensure-compatible-mypy-version branch from 24ad2e4 to bc6849f Compare June 23, 2023 12:18
@eineruntervielen
Copy link

thank you for you reply

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Error importing plugin "classes.contrib.mypy.classes_plugin" cannot import name 'union_items' from 'mypy.types'
3 participants