Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

WIP 6.0 major #2352

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

WIP 6.0 major #2352

wants to merge 4 commits into from

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Jul 23, 2024

Copy link

github-actions bot commented Jul 23, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- WIP 6.0 major ([#2352](https://github.com/getsentry/sentry-ruby/pull/2352))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 913c75e

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.98%. Comparing base (9446a30) to head (913c75e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2352      +/-   ##
==========================================
- Coverage   98.16%   97.98%   -0.19%     
==========================================
  Files         126      126              
  Lines        4741     4714      -27     
==========================================
- Hits         4654     4619      -35     
- Misses         87       95       +8     
Components Coverage Δ
sentry-ruby 98.48% <100.00%> (-0.04%) ⬇️
sentry-rails 96.57% <100.00%> (-0.49%) ⬇️
sentry-sidekiq 95.73% <ø> (-1.90%) ⬇️
sentry-resque 92.85% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-rails/lib/sentry/rails/active_job.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/background_worker.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/breadcrumb.rb 96.96% <100.00%> (ø)
sentry-ruby/lib/sentry/breadcrumb_buffer.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/check_in_event.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/client.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/configuration.rb 98.86% <ø> (-0.03%) ⬇️
sentry-ruby/lib/sentry/cron/monitor_config.rb 95.45% <100.00%> (ø)
sentry-ruby/lib/sentry/cron/monitor_schedule.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/error_event.rb 100.00% <100.00%> (ø)
... and 16 more

... and 6 files with indirect coverage changes

* Migrate from to_hash to to_h

As @solnic pointed out in #2350 (comment)
`to_hash` has special meaning in Ruby and could be called implicitly
in contexts like double splatting argument. So we should switch to `to_h`
to avoid potential issues.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants