-
-
Notifications
You must be signed in to change notification settings - Fork 205
docs: link to replacements of deprecated functions #1823
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
Would you like to share the code that did the search+replace? We might run into conflicts, I'd also like to tweak a detail. |
There's no code. I did it with a text editor, and regex find/replace, so that I could review at least a subset of replacements before proceeding. |
I now see you asked, |
I can fix this without too much trouble. |
@krlmlr, this is done now. Replacement across all files in
I didn't notice anything going wrong. But I did notice an unusual way to refer to a class (use of parentheses), which is also fixed now. |
This is a simple find-and-replace job to actually link to replacements of deprecated functions instead of simply mentioning them.
Is there a reason it wasn't done this way? Perhaps it is not standard in the R world?
Do we want
[`some_fun()`]
(inline code) or simply[some_fun()]
(not in code style)? I see both styles used at the moment.I am hoping this encourages people to upgrade to the non-deprecated alternative more quickly. I still see tutorials published with the old names ...
The search pattern was: