-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(react/fdc) add validateReactArgs
for parsing arguments to variadic generated SDK query hook function signatures
#174
Merged
Ehesp
merged 12 commits into
invertase:main
from
stephenarosaj:stephenarosaj/validateargs
Mar 25, 2025
Merged
feat(react/fdc) add validateReactArgs
for parsing arguments to variadic generated SDK query hook function signatures
#174
Ehesp
merged 12 commits into
invertase:main
from
stephenarosaj:stephenarosaj/validateargs
Mar 25, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/tanstack-query-firebase~174 Documentation is deployed and generated using docs.page. |
validateReactArgs
for parsing arguments to variadic generated SDK query hook function signatures
maneesht
reviewed
Mar 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you format these files?
maneesht
approved these changes
Mar 19, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when queries were called from the generated React SDK, if options were being provided without a
DataConnect
argument (whether variables were required or not), options weren't being parsed properly and weren't passed to the underlyinguseDataConnectQuery
function. This is because the generated TS signatures allowed foroptions
to be provided as the second argument aftervars
, but at runtime thevalidateArgs
function from the Core JS SDK only expects the two args to bedcOrVars
andvars
.This PR adds a new function,
validateReactArgs
, which accounts for there being three arguments to parse (dcOrVars
,varsOrOptions
, andoptions
) rather than just two.