Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(react/fdc) add validateReactArgs for parsing arguments to variadic generated SDK query hook function signatures #174

Merged
merged 12 commits into from
Mar 25, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update unit tests for validateReactArgs
  • Loading branch information
stephenarosaj committed Mar 17, 2025
commit 7b57607bd57f5f0554967da04b2eb40874bfa8ed
32 changes: 15 additions & 17 deletions packages/react/src/data-connect/validateReactArgs.test.tsx
Original file line number Diff line number Diff line change
@@ -11,9 +11,7 @@ describe("validateReactArgs", () => {
const dataConnect = getDataConnect(connectorConfig);

const emptyObjectVars = {};
const strictlyRequiredArgs = { limit: 5 };
const strictlyOptionalVars = { title: "a" };
const allArgs = { limit: 5, title: "a" };
const nonEmptyVars = { limit: 5 };

const options = { meta: { hasOptions: true } };

@@ -104,10 +102,10 @@ describe("validateReactArgs", () => {
},
{
argsDescription: "only vars are provided",
dcOrVarsOrOptions: strictlyOptionalVars,
dcOrVarsOrOptions: nonEmptyVars,
varsOrOptions: undefined,
options: undefined,
expectedInputVars: strictlyOptionalVars,
expectedInputVars: nonEmptyVars,
expectedInputOpts: undefined,
},
{
@@ -121,9 +119,9 @@ describe("validateReactArgs", () => {
{
argsDescription: "dataconnect and vars are provided",
dcOrVarsOrOptions: dataConnect,
varsOrOptions: strictlyOptionalVars,
varsOrOptions: nonEmptyVars,
options: undefined,
expectedInputVars: strictlyOptionalVars,
expectedInputVars: nonEmptyVars,
expectedInputOpts: undefined,
},
{
@@ -137,9 +135,9 @@ describe("validateReactArgs", () => {
{
argsDescription: "dataconnect and vars and options are provided",
dcOrVarsOrOptions: dataConnect,
varsOrOptions: strictlyOptionalVars,
varsOrOptions: nonEmptyVars,
options: options,
expectedInputVars: strictlyOptionalVars,
expectedInputVars: nonEmptyVars,
expectedInputOpts: options,
},
])(
@@ -183,34 +181,34 @@ describe("validateReactArgs", () => {
test.each([
{
argsDescription: "only vars are provided",
dcOrVarsOrOptions: strictlyRequiredArgs,
dcOrVarsOrOptions: nonEmptyVars,
varsOrOptions: undefined,
options: undefined,
expectedInputVars: strictlyRequiredArgs,
expectedInputVars: nonEmptyVars,
expectedInputOpts: undefined,
},
{
argsDescription: "dataconnect and vars are provided",
dcOrVarsOrOptions: dataConnect,
varsOrOptions: strictlyRequiredArgs,
varsOrOptions: nonEmptyVars,
options: undefined,
expectedInputVars: strictlyRequiredArgs,
expectedInputVars: nonEmptyVars,
expectedInputOpts: undefined,
},
{
argsDescription: "vars and options are provided",
dcOrVarsOrOptions: strictlyRequiredArgs,
dcOrVarsOrOptions: nonEmptyVars,
varsOrOptions: options,
options: undefined,
expectedInputVars: strictlyRequiredArgs,
expectedInputVars: nonEmptyVars,
expectedInputOpts: options,
},
{
argsDescription: "dataconnect and vars and options are provided",
dcOrVarsOrOptions: dataConnect,
varsOrOptions: strictlyRequiredArgs,
varsOrOptions: nonEmptyVars,
options: options,
expectedInputVars: strictlyRequiredArgs,
expectedInputVars: nonEmptyVars,
expectedInputOpts: options,
},
])(