-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feature/upgrade to nx 20 #117
Conversation
- Bump most of the dependencies to their latest - Don't change tsquery, that requires refactoring - Refactor code to use `projectConfigurations` instead of `workspace`
- Fix test issues due to typescript update. @see phenomnomnominal/tsquery#98
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7415607. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
I went ahead and did some digging in the NX codebase (their documentation is not so good 🤷 ) and found this -> https://github.com/nrwl/nx/blame/d131b0b67709560d816b0df394c762e72a7b51d6/packages/nx/src/config/misc-interfaces.ts#L248-L253C60 {
/**
* Deprecated. Use projectsConfigurations or nxJsonConfiguration
* The full workspace configuration
* @todo(vsavkin): remove after v17
*/
workspace?: ProjectsConfigurations & NxJsonConfiguration;
} This was Removed in NX 20, but because of this, it does mean that this PR should be feasible for NX 16 and up |
hey @koliveira15 , let me know if there is anything I can do to help out with this PR - 🙏 |
Hey @koliveira15 , please let me know if there is anything else needed for this PR. As an aside, it might be worthwhile contacting NX and making this an official plugin 🤔 IMO static analysis is integral to development pipeline and I personally would push strongly for its inclusion to the NX family |
@koliveira15 Anything I can do to help? This is becoming a blocker in our repository as it precludes us from updating |
since he is busy, I will fork it out and move it to 20. we are having the same blocker as it is critical for us to use |
It seems I am unable to create the package as I'm tied to several things at work. If there is no update in 15 days, I will retry to fork it and somehow own it... or worst thing to fork it into work and maintain it ourselves... |
Hey @koliveira15 Just checking to see if this PR can get merged |
Add back migrations.json file
# Conflicts: # packages/nx-sonarqube/package.json
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
build-docs
command)What is the current behavior?
Currently, nx-sonarqube fails when using NX 20
Closes #116
This also fixes an issue with tsquery and latest typescript. See this bug phenomnomnominal/tsquery#98
What is the new behavior?
Updated the usages of
workspace
toprojectConfigurations
Does this PR introduce a breaking change?
It has been tested to work correctly with NX 20 and NX 19. I have not tested with other versions of NX
Other information