Use scaledDirectionToPoint in occlusion computations #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
I've been having issues with what seems like incorrectly culled tiles (especially at z0) so I started taking a look at the
horizonOcclusionPointvalues. I have no true understanding of the math involved 😅 but in comparing the implementation here with https://github.com/CesiumGS/cesium/blob/9295450e64c3077d96ad579012068ea05f97842c/packages/engine/Source/Core/EllipsoidalOccluder.js#L398I noticed this implementation wasn't making use of scaledDirectionToPoint like in the reference implementation.
At least on my side, this change has resulted in fixing the tiles being incorrectly culled in Cesium. I should probably add tests, and validate some other things first. Putting this up early for feedback in case I'm missing something.