Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use scaledDirectionToPoint in occlusion computations #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use scaledDirectionToPoint in occlusion computations #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions quantized_mesh_encoder/occlusion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,13 @@ def occlusion_point(
# Scale positions relative to ellipsoid
positions /= cartesian_ellipsoid

# Scale center relative to ellipsoid
bounding_center /= cartesian_ellipsoid
# Scale center relative to ellipsoid and normalize
# see https://github.com/CesiumGS/cesium/blob/9295450e64c3077d96ad579012068ea05f97842c/packages/engine/Source/Core/EllipsoidalOccluder.js#L398
scaledSpaceDirectionToPoint = bounding_center / cartesian_ellipsoid
scaledSpaceDirectionToPoint /= np.linalg.norm(scaledSpaceDirectionToPoint)

# Find magnitudes necessary for each position to not be visible
magnitudes = compute_magnitude(positions, bounding_center)
magnitudes = compute_magnitude(positions, scaledSpaceDirectionToPoint)

# Multiply by maximum magnitude and rescale to ellipsoid surface
return bounding_center * magnitudes.max() * cartesian_ellipsoid
return scaledSpaceDirectionToPoint * magnitudes.max() * cartesian_ellipsoid