ci(e2e): add same Windows perf config as for integration tests #7207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
force-pushed
the
ci/improve-windows-e2e-perf
branch
from
823e45a to
e9a6952
Compare
serhalp
commented
Apr 15, 2025
| @@ -17,15 +17,19 @@ jobs: | |||
| name: E2E Windows tests | |||
| runs-on: ${{ matrix.os }} | |||
| timeout-minutes: 20 | |||
| env: | |||
| DEBUG: true | |||
There was a problem hiding this comment.
who knows, this could have been hurting perf too. It looks like this has been here from the very start. 🤷🏼
We have this in the integration test setup, and e2e tests are excruciatingly slow on Windows (4-7 mins PER TEST), so let's give this a try.
serhalp
force-pushed
the
ci/improve-windows-e2e-perf
branch
from
e9a6952 to
c0550aa
Compare
ndhoule
approved these changes
Apr 15, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have this incantation in the integration test setup, and e2e tests are excruciatingly slow on Windows (4-7 mins PER TEST, vs. 400-900ms for Ubuntu/macOS), so let's give this a try.