Skip to content

ci(e2e): add same Windows perf config as for integration tests #7207

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

ci(e2e): add same Windows perf config as for integration tests #7207

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae27124
ci: remove leftover DEBUG env vars
serhalp Apr 15, 2025
c0550aa
ci(e2e): add same Windows perf config as for integration tests
serhalp Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,19 @@ jobs:
name: E2E Windows tests
runs-on: ${{ matrix.os }}
timeout-minutes: 20
env:
DEBUG: true
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who knows, this could have been hurting perf too. It looks like this has been here from the very start. 🤷🏼

strategy:
matrix:
os: [windows-latest]
# Pinning 20.x version as a temporary workaround due to this https://github.com/nodejs/node/issues/52884
node-version: ['18.14.0', '20.12.2', '22']
fail-fast: false
steps:
# This improves Windows network performance. We need this since we open many ports in our tests.
- name: Increase Windows port limit and reduce time wait delay
run: |
netsh int ipv4 set dynamicport tcp start=1025 num=64511
REG ADD HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\TCPIP\Parameters /v TcpTimedWaitDelay /t REG_DWORD /d 30 /f

- name: Git checkout
uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -72,8 +76,6 @@ jobs:
name: E2E
runs-on: ${{ matrix.os }}
timeout-minutes: 10
env:
DEBUG: true
strategy:
matrix:
os: [ubuntu-latest, macOS-latest]
Expand Down
Loading