fix(HelperTextItem): allowed removal of SR text element #11704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-11704.surge.sh A11y report: https://patternfly-react-pr-11704-a11y.surge.sh |
|
Looks like it would work! Thanks for making it happen @thatblindgeye |
wise-king-sullyman
approved these changes
Mar 25, 2025
kmcfaul
approved these changes
Apr 8, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #11678
@Venefilyn For now I've allowed passing an empty string to remove the entire SR text element. As far as I'm aware there isn't an applicable aria attribute to use in place of it, and removing the SR text completely right now would be considered breaking. Please let me know if this is a viable solution until we can possibly revisit in our next breaking change.
Additional issues: