Use urdf/model.hpp for rolling #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
christophfroehlich,
LukasMacha97,
mcbed,
olivier-stasse,
peterdavidfagan and
saikishor
saikishor
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Hello @nakul-py
Please also remove these redundant lines from here :
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1476 +/- ##
==========================================
- Coverage 83.83% 83.81% -0.02%
==========================================
Files 122 122
Lines 11120 11120
Branches 944 943 -1
==========================================
- Hits 9322 9320 -2
- Misses 1489 1491 +2
Partials 309 309
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Hey @saikishor will you also review this pull request #1475 |
Sure, when I get some time. I'll do it. |
saikishor
changed the title
bmagyar
reviewed
Jan 9, 2025
saikishor
dismissed
their stale review
Missed the urdf/model.h include while reviewing
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
christophfroehlich
previously approved these changes
Jan 9, 2025
christophfroehlich
dismissed stale reviews from saikishor and themself
via
c602975
christophfroehlich
approved these changes
Jan 9, 2025
saikishor
approved these changes
Jan 9, 2025
mamueluth
pushed a commit
to StoglRobotics-forks/ros2_controllers
that referenced
this pull request
Mar 14, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
urdf/model.hwith conditional includes usingurdf/model.hppfor Rolling.rclcpp/version.h.Solve #1473 (review)