-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add GPSBroadcaster #1554
base: master
Are you sure you want to change the base?
Add GPSBroadcaster #1554
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1554 +/- ##
==========================================
+ Coverage 84.26% 84.28% +0.02%
==========================================
Files 123 126 +3
Lines 11358 11508 +150
Branches 961 962 +1
==========================================
+ Hits 9571 9700 +129
- Misses 1471 1492 +21
Partials 316 316
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this new controller. I've found some on quick look
I'll send more reviews during this week.
gps_sensor_broadcaster/include/gps_sensor_broadcaster/gps_sensor_broadcaster.hpp
Outdated
Show resolved
Hide resolved
Conceptual question: We also have battery_state_broadcaster. Now we get a Now I can imagine we get a lot of future PR's creating packages for all items in this list: sensor_msgs. Would it make sense to template this such that we can simply send any message from sensor_msgs? |
@Timple Perhaps you're right; it could be a template class. However, since all sensors would use a different set of state interfaces, we would probably need to create a bunch of new semantic components (which can be done). Also, it looks like this decision was already settled. We've got pose/IMU/range broadcasters, and templating them would affect existing configs. |
As in the title. I'm open to any suggestions.