Skip to content

[CI] Time out from test_force_torque_sensor_broadcaster (backport #1586) #1611

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 5 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 26, 2025

This change attempts to debug and reproduce CI failures: #1574 and #1559.

In both issues, it appears that the timeout was caused by the test "InterfaceNames_Configure_Success", which primarily tests the on_configure function. No hypothesis has been established so far.

  • The code in "InterfaceNames_Configure_Success" is straightforward.
  • I’ve reviewed the on_configure function in ForceTorqueSensorBroadcaster and the changes introduced around the time of the failure. Other than a change made in realtime_tools regarding RTPublisher, no other changes were found that could impact on_configure.

This is an automatic backport of pull request #1586 done by [Mergify](https://mergify.com).

(cherry picked from commit 996f030)

# Conflicts:
#	force_torque_sensor_broadcaster/test/test_force_torque_sensor_broadcaster.cpp
@mergify mergify bot added the conflicts label Mar 26, 2025
Copy link
Contributor Author

mergify bot commented Mar 26, 2025

Cherry-pick of 996f030 has failed:

On branch mergify/bp/humble/pr-1586
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 996f030.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   force_torque_sensor_broadcaster/test/test_force_torque_sensor_broadcaster.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.13%. Comparing base (67628b5) to head (6126bef).
Report is 1 commits behind head on humble.

Files with missing lines Patch % Lines
...ster/test/test_force_torque_sensor_broadcaster.cpp 69.23% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           humble    #1611   +/-   ##
=======================================
  Coverage   67.12%   67.13%           
=======================================
  Files         122      122           
  Lines       14435    14446   +11     
  Branches     8903     8911    +8     
=======================================
+ Hits         9690     9698    +8     
+ Misses       1460     1457    -3     
- Partials     3285     3291    +6     
Flag Coverage Δ
unittests 67.13% <69.23%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ster/test/test_force_torque_sensor_broadcaster.cpp 62.08% <69.23%> (+0.09%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich marked this pull request as draft March 28, 2025 08:19
…sensor_broadcaster (backport #1622) (#1626)

Co-authored-by: Julia Jia <juliajster@gmail.com>
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1586 branch April 4, 2025 06:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants