Skip to content

In zen mode overflowing content should be scrollable #241

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

In zen mode overflowing content should be scrollable #241

wants to merge 1 commit into from

Conversation

Dineshs91
Copy link
Contributor

@Dineshs91 Dineshs91 commented Apr 16, 2025 •
edited
Loading

TL;DR

Changed the body overflow property from hidden to scroll in writer mode.

What changed?

Modified the CSS in the changeWriterMode function to set the body's overflow property to scroll instead of hidden.

How to test?

  1. Enable writer mode in the application
  2. Verify that content can now be scrolled when it exceeds the viewport height
  3. Check that the scrolling behavior works correctly across different content lengths

Why make this change?

The previous overflow: hidden setting prevented users from scrolling through content that exceeded the viewport height in writer mode. This change ensures users can access all content while maintaining the clean writer mode interface.

Fix MIN-31 and #169

CleanShot 2025-04-16 at 22.34.55.mp4 (uploaded via Graphite)

@Dineshs91 Graphite App
Copy link
Contributor Author

Dineshs91 commented Apr 16, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dineshs91 Dineshs91 mentioned this pull request Apr 16, 2025
Merged
@Dineshs91 Dineshs91 requested a review from linuz90 April 16, 2025 13:19
@Dineshs91 Dineshs91 mentioned this pull request Apr 16, 2025
Open
@Dineshs91 Dineshs91 marked this pull request as ready for review April 16, 2025 15:06
@Dineshs91 Dineshs91 mentioned this pull request Apr 16, 2025
Open
@Dineshs91 Dineshs91 force-pushed the dinesh/04-16-in_zen_mode_overflowing_content_should_be_scrollable branch from a1900dc to 0399e8d Compare April 30, 2025 14:20
@Dineshs91 Dineshs91 requested a review from linuz90 April 30, 2025 14:21
linuz90
linuz90 previously approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@linuz90 linuz90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Dineshs91 Graphite App
Copy link
Contributor Author

Dineshs91 commented Apr 30, 2025 •
edited
Loading

Merge activity

  • Apr 30, 11:26 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 30, 11:27 AM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 30, 11:31 AM EDT: Graphite couldn't merge this PR because it failed for an unknown reason.

@Dineshs91 Dineshs91 changed the base branch from dinesh/04-16-don_t_open_welcome_page_on_extension_update to graphite-base/241 April 30, 2025 15:26
@Dineshs91 Dineshs91 changed the base branch from graphite-base/241 to main April 30, 2025 15:26
@Dineshs91 Dineshs91 dismissed linuz90’s stale review April 30, 2025 15:26

The base branch was changed.

@Dineshs91 Dineshs91 force-pushed the dinesh/04-16-in_zen_mode_overflowing_content_should_be_scrollable branch from 0399e8d to f805b96 Compare April 30, 2025 15:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@linuz90 linuz90 linuz90 left review comments

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dineshs91 @linuz90