Skip to content

Add an option to hide bookmark count #243

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: dinesh/04-16-fix_notification_count_and_red_dot_not_hidden_in_title
Choose a base branch
from

Conversation

Dineshs91
Copy link
Contributor

@Dineshs91 Dineshs91 commented Apr 16, 2025

Add option to hide bookmark count from tweets

This PR adds a new feature to hide bookmark counts from tweets, similar to existing options for hiding reply, retweet, like, and follower counts.

Changes include:

  • Added a new storage key KeyBookmarkCount
  • Implemented the changeBookmarkCount function to toggle visibility of bookmark counts
  • Added a new checkbox option in the Vanity Checkboxes component
  • Updated the "Hide All" option to include bookmark counts

The bookmark count hiding feature works by setting the visibility of the span elements within bookmark and removeBookmark elements to hidden when enabled.

Fix MIN-28 and #180

CleanShot 2025-04-16 at 22.27.49.mp4 (uploaded via Graphite)

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dineshs91 Dineshs91 requested a review from linuz90 April 16, 2025 16:56
@Dineshs91 Dineshs91 marked this pull request as ready for review April 16, 2025 16:56
Add a new option under engagements under posts in the popup
@Dineshs91 Dineshs91 force-pushed the dinesh/04-16-add_an_option_to_hide_bookmark_count branch from 4fe229c to 580439f Compare April 30, 2025 14:20
@Dineshs91 Dineshs91 force-pushed the dinesh/04-16-fix_notification_count_and_red_dot_not_hidden_in_title branch from 52a172c to 3b10bc3 Compare April 30, 2025 14:20
Copy link
Contributor Author

Dineshs91 commented Apr 30, 2025

Merge activity

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants